Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reset_email_by_code template #1014

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Jan 9, 2025

🔧 Changes

Supporting an new email template - reset_email_by_code used for change password (code)

API changes for connection to support verification_method for connections using Email as Identifier

📚 References

https://auth0.com/docs/api/management/v2/email-templates/get-email-templates-by-template-name#:~:text=%2C%20reset_email%2C-,reset_email_by_code,-%2C%20welcome_email%2C

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (3e4f7ce) to head (0d42545).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1014   +/-   ##
=======================================
  Coverage   80.10%   80.10%           
=======================================
  Files         125      125           
  Lines        4568     4569    +1     
  Branches      888      888           
=======================================
+ Hits         3659     3660    +1     
  Misses        539      539           
  Partials      370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramya18101 ramya18101 marked this pull request as ready for review January 9, 2025 09:08
@ramya18101 ramya18101 requested a review from a team as a code owner January 9, 2025 09:08
@kushalshit27 kushalshit27 marked this pull request as draft January 9, 2025 11:07
Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples , and doc need to be updated

@ramya18101 ramya18101 marked this pull request as ready for review January 28, 2025 03:57
Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramya18101 ramya18101 merged commit 313fb42 into master Jan 29, 2025
8 checks passed
@ramya18101 ramya18101 deleted the DXCDT-791-support-password-reset-by-otp-code branch January 29, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants